Re: [PATCH v3 11/11] dm-zoned: ensure only power of 2 zone sizes are allowed

[Pankaj Raghav]

>> ---
>>  drivers/md/dm-zone.c | 12 ++++++++++++
>>  1 file changed, 12 insertions(+)
>>
>> diff --git a/drivers/md/dm-zone.c b/drivers/md/dm-zone.c
>> index 3e7b1fe15..27dc4ddf2 100644
>> --- a/drivers/md/dm-zone.c
>> +++ b/drivers/md/dm-zone.c
>> @@ -231,6 +231,18 @@ static int dm_revalidate_zones(struct mapped_device *md, struct dm_table *t)
>>  	struct request_queue *q = md->queue;
>>  	unsigned int noio_flag;
>>  	int ret;
>> +	struct block_device *bdev = md->disk->part0;
>> +	sector_t zone_sectors;
>> +	char bname[BDEVNAME_SIZE];
>> +
>> +	zone_sectors = bdev_zone_sectors(bdev);
>> +
>> +	if (!is_power_of_2(zone_sectors)) {
>> +		DMWARN("%s: %s only power of two zone size supported\n",
>> +		       dm_device_name(md),
>> +		       bdevname(bdev, bname));
>> +		return 1;
> 
> return -EINVAL;
> 
> The error propagates to dm_table_set_restrictions() so a proper error code must
> be returned.
> 
Good point. I will add this in the next rev.