Re: [PATCH 2/3] tty: n_gsm: fix mux activation issues in gsm_config()

From: Jiri Slaby
Date: Mon May 09 2022 - 07:13:48 EST


On 09. 05. 22, 13:03, Starke, Daniel wrote:
static int gsm_config(struct gsm_mux *gsm, struct gsm_config *c)
{
+ int ret = 0;

Why is the initialization needed? You can as well declare the variable only inside the if below.

You are right, this was unneeded. But this patch was already included in
the tty-linus branch. Shall I resubmit it nevertheless?

In that case, you can only send a fixup patch...

thanks,
--
js
suse labs