Re: [PATCH] ata: simplify the return expression of brcm_ahci_remove

[Damien Le Moal]

On 2022/05/05 11:21, cgel.zte@xxxxxxxxx wrote:
> From: Minghao Chi <chi.minghao@xxxxxxxxxx>
> 
> Simplify the return expression.
> 
> Reported-by: Zeal Robot <zealci@xxxxxxxxxx>
> Signed-off-by: Minghao Chi <chi.minghao@xxxxxxxxxx>
> ---
>  drivers/ata/ahci_brcm.c | 7 +------
>  1 file changed, 1 insertion(+), 6 deletions(-)
> 
> diff --git a/drivers/ata/ahci_brcm.c b/drivers/ata/ahci_brcm.c
> index ab8552b1ff2a..f61795c546cf 100644
> --- a/drivers/ata/ahci_brcm.c
> +++ b/drivers/ata/ahci_brcm.c
> @@ -549,15 +549,10 @@ static int brcm_ahci_remove(struct platform_device *pdev)
>  	struct ata_host *host = dev_get_drvdata(&pdev->dev);
>  	struct ahci_host_priv *hpriv = host->private_data;
>  	struct brcm_ahci_priv *priv = hpriv->plat_data;
> -	int ret;
>  
>  	brcm_sata_phys_disable(priv);
>  
> -	ret = ata_platform_remove_one(pdev);
> -	if (ret)
> -		return ret;
> -
> -	return 0;
> +	return ata_platform_remove_one(pdev);
>  }
>  
>  static void brcm_ahci_shutdown(struct platform_device *pdev)

Applied to for-5.19. Thanks !

-- 
Damien Le Moal
Western Digital Research