Re: [RFC v2 31/39] sound: add HAS_IOPORT dependencies

[Niklas Schnelle]

On Mon, 2022-05-09 at 12:07 +0200, Takashi Iwai wrote:
> On Mon, 09 May 2022 11:20:33 +0200,
> Arnd Bergmann wrote:
> > On Mon, May 9, 2022 at 10:53 AM Takashi Iwai <tiwai@xxxxxxx> wrote:
> > > On Fri, 29 Apr 2022 15:50:54 +0200, Niklas Schnelle wrote:
> > > >  config SND_OPL3_LIB
> > > >       tristate
> > > > +     depends on HAS_IOPPORT
> > > >       select SND_TIMER
> > > >       select SND_HWDEP
> > > >       select SND_SEQ_DEVICE if SND_SEQUENCER != n
> > > 
> > > Both of those are the items to be reverse-selected, so cannot fulfill
> > > the dependency with depends-on.  That is, the items that select those
> > > should have the dependency on HAS_IOPORT instead.
> > > 
> > > That is, a change like below:
> > > 
> > > > --- a/sound/isa/Kconfig
> > > > +++ b/sound/isa/Kconfig
> > > > @@ -31,7 +31,7 @@ if SND_ISA
> > > > 
> > > >  config SND_ADLIB
> > > >       tristate "AdLib FM card"
> > > > -     select SND_OPL3_LIB
> > > > +     depends on SND_OPL3_LIB
> > > 
> > > ... won't work.  CONFIG_SND_OPL3_LIB is not enabled by itself but only
> > > to be selected.
> > 
> > Right, I missed that in my review. Not sure if this was a mistake in
> > my original patch or if it started in a later version.

I added this part recently I think even after your review so the fault
is entirely mine.

> > 
> > I think for the ISA drivers, I would still add 'depends on HAS_IOPORT'
> > to both CONFIG_SND_ISA and CONFIG_SND_OPL3_LIB if only to
> > make it easier to understand, even though CONFIG_ISA requires
> > HAS_IOPORT already, and CONFIG_SND_OPL3_LIB cannot be
> > selected by itself.
> 
> Yes, that makes sense.

Good, incorporating this now and it looks like this works.

> 
> > For the PCI drivers, I think we need to add the same dependency
> > on anything that either selects SND_OPL3_LIB or calls inb()/outb()
> > directly.
> 
> Agreed.

Same as above and thanks for spotting my mistake.