Re: [v3 PATCH 5/8] mm: khugepaged: make khugepaged_enter() void function

From: Vlastimil Babka
Date: Mon May 09 2022 - 09:47:22 EST


On 4/4/22 22:02, Yang Shi wrote:
> The most callers of khugepaged_enter() don't care about the return
> value. Only dup_mmap(), anonymous THP page fault and MADV_HUGEPAGE handle
> the error by returning -ENOMEM. Actually it is not harmful for them to
> ignore the error case either. It also sounds overkilling to fail fork()
> and page fault early due to khugepaged_enter() error, and MADV_HUGEPAGE
> does set VM_HUGEPAGE flag regardless of the error.
>
> Acked-by: Song Liu <song@xxxxxxxxxx>
> Signed-off-by: Yang Shi <shy828301@xxxxxxxxx>

Acked-by: Vlastimil Babka <vbabka@xxxxxxx>