Re: [PATCH] mm/shmem: initialize folio to NULL

From: Matthew Wilcox
Date: Mon May 09 2022 - 10:00:01 EST


On Mon, May 09, 2022 at 08:31:16AM -0400, Tom Rix wrote:
> The clang build fails with
> mm/shmem.c:1704:7: error: variable 'folio' is used uninitialized whenever 'if' condition is true [-Werror,-Wsometimes-uninitialized]
> if (!page) {
> ^~~~~
> The error handler for !page jumps to an if-check for an unset folio.
> So initialize folio to NULL.

I appreciate you're trying to help, but the fourth report of a problem
adds more noise than utility.

https://lore.kernel.org/linux-mm/?q=shmem+folio

shows emails about this from the cgelbot, Dan Carpenter, SeongJae Park,
Colin King, Nathan Chancellor and Sebastian Siewior. So actually you
were seventh, not fourth.