Re: [RFC PATCH] ubd: add io_uring based userspace block driver

[Randy Dunlap]

On 5/9/22 02:23, Ming Lei wrote:
> diff --git a/drivers/block/Kconfig b/drivers/block/Kconfig
> index fdb81f2794cd..3893ccd82e8a 100644
> --- a/drivers/block/Kconfig
> +++ b/drivers/block/Kconfig
> @@ -408,6 +408,13 @@ config BLK_DEV_RBD
>  
>  	  If unsure, say N.
>  
> +config BLK_DEV_USER_BLK_DRV
> +	bool "Userspace block driver"
> +	select IO_URING
> +	default y

Any "default y" driver is highly questionable and needs to be justified.

Also: why is it bool instead of tristate?

> +	help
> +          io uring based userspace block driver.

-- 
~Randy