Re: [PATCH v1 1/2] serial: 8250_dw: Use devm_add_action_or_reset()

From: Marion & Christophe JAILLET
Date: Mon May 09 2022 - 14:18:19 EST



Le 09/05/2022 à 19:59, Andy Shevchenko a écrit :
On Mon, May 9, 2022 at 7:49 PM Christophe JAILLET
<christophe.jaillet@xxxxxxxxxx> wrote:
Le 09/05/2022 à 19:21, Andy Shevchenko a écrit :
...

+static void dw8250_clk_disable_unprepare(void *data)
+{
+ clk_disable_unprepare(data);
+}
we already have several time this function in different drivers.
Maybe, it would be nice to have something standart for it.

A devm_clk_prepare_enable() or something devm-helpers.h ([1])
Seems you missed the full story. We tried to add that several times
[1] and CCF maintainers refused all the time. You may work with them
to convince them.

[1]: https://lore.kernel.org/linux-clk/20210304221247.488173-2-linux@xxxxxxxxxxxxxxxxxx/
(the latest one AFAIK)

LoL, got it.

Sorry for the noise.

CJ