Re: drivers/hwmon/ltq-cputemp.c:23:2: error: call to undeclared function 'ltq_cgu_w32'; ISO C99 and later do not support implicit function declarations

[Guenter Roeck]

On 5/9/22 01:17, Florian Eckert wrote:
> > > vim +/ltq_cgu_w32 +23 drivers/hwmon/ltq-cputemp.c
> > >
> > > 7074d0a9275860 Florian Eckert 2017-09-01  20
> > > 7074d0a9275860 Florian Eckert 2017-09-01  21  static void ltq_cputemp_enable(void)
> > > 7074d0a9275860 Florian Eckert 2017-09-01  22  {
> > > 7074d0a9275860 Florian Eckert 2017-09-01 @23     ltq_cgu_w32(ltq_cgu_r32(CGU_GPHY1_CR) | CGU_TEMP_PD, CGU_GPHY1_CR);
> > > 7074d0a9275860 Florian Eckert 2017-09-01  24  }
> > > 7074d0a9275860 Florian Eckert 2017-09-01  25
> > >
> > > :::::: The code at line 23 was first introduced by commit
> > > :::::: 7074d0a92758603369655ef5d4f49e6caaae0b4e hwmon: (ltq-cputemp) add cpu temp sensor driver
> > >
> > > :::::: TO: Florian Eckert <fe@xxxxxxxxxx>
> > > :::::: CC: Guenter Roeck <linux@xxxxxxxxxxxx>
> >
> > This driver builds fine if I change it from SOC_FALCON to SOC_XWAY.
> > Maybe its Kconfig entry should be stronger?
> >
> > config SENSORS_LTQ_CPUTEMP
> >     bool "Lantiq cpu temperature sensor driver"
> > -    depends on LANTIQ
> > +    depends on SOC_XWAY
>
> Fine with me. I think it's better to narrow it down.

I'll be happy to accept a patch doing that.

Guenter