Re: [PATCH v2 3/3] dt-bindings: mediatek: add ethdr definition for mt8195

[Rex-BC Chen]

On Mon, 2022-05-09 at 18:50 +0800, AngeloGioacchino Del Regno wrote:
> Il 09/05/22 12:44, Krzysztof Kozlowski ha scritto:
> > On 09/05/2022 10:54, Rex-BC Chen wrote:
> > > > > +    soc {
> > > > > +        #address-cells = <2>;
> > > > > +        #size-cells = <2>;
> > > > > +
> > > > > +        disp_ethdr@1c114000 {
> > > > 
> > > > No underscores in node name. Generic node names, so display-
> > > > controller?
> > > > 
> > > 
> > > OK, we will change the node name to ethdr like in dts
> > > like this:
> > > ethdr0: ethdr@1c114000 {
> > > ...
> > > }
> > 
> > Is "ethdr" a generic name? Is it an abbreviation of "EnergyTrace™
> > High
> > Dynamic Range"? If yes, it also looks specific to Texas
> > Instruments...
> > 
> > Best regards,
> > Krzysztof
> 
> 
> That's mediatek-drm, and this refers to the HDR block in the display
> IP...
> 
> Though, I have no idea of what "ET" stands for in "ETHDR", so, it
> would be
> definitely nice if MediaTek can write the meaning in the description,
> like
> 
> description:
>    ETHDR (E??? T??? High Dynamic Range) is designed for HDR video and
> ...blah
> 
> Cheers,
> Angelo

Hello Krzysztof and Angelo,

"ET" is actually meaningless.
ET is one of mediatek departments and it's where the engine from.
Therefore, I think we will add description like this:
> ETHDR (ET High Dynamic Range) is a MediaTek internal HDR engine and
> designed for HDR video...

BRs,
Rex