Re: [PATCH] PCI: mediatek-gen3: Assert resets to ensure expected init state

[AngeloGioacchino Del Regno]

Il 09/05/22 19:16, Bjorn Helgaas ha scritto:
> On Mon, May 09, 2022 at 02:18:34PM +0200, AngeloGioacchino Del Regno wrote:
> > Il 04/04/22 16:48, AngeloGioacchino Del Regno ha scritto:
> > > The controller may have been left out of reset by the bootloader,
> > > in which case, before the powerup sequence, the controller will be
> > > found preconfigured with values that were set before booting the
> > > kernel: this produces a controller failure, with the result of
> > > a failure during the mtk_pcie_startup_port() sequence as the PCIe
> > > link never gets up.
> > >
> > > To ensure that we get a clean start in an expected state, assert
> > > both the PHY and MAC resets before executing the controller
> > > power-up sequence.
> > >
> > > Fixes: d3bf75b579b9 ("PCI: mediatek-gen3: Add MediaTek Gen3 driver for MT8192")
> > > Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@xxxxxxxxxxxxx>
> >
> > Friendly ping for an important fix :-)
>
> d3bf75b579b9 appeared in v5.13-rc1 (May 2021, a year ago), so I assume
> this is important for v5.19, but not urgent enough to require being in
> v5.18.  Right?

Hello Bjorn,
no it's not *very* urgent, as MediaTek devices that do require this will be
in v5.19 anyway...

Thanks,
Angelo