Re: [PATCH] memory: OMAP_GPMC should depend on ARCH_OMAP2PLUS || ARCH_K3

[Roger Quadros]

Geert,

On 10/05/2022 11:17, Geert Uytterhoeven wrote:
> Hi Roger,
> 
> On Tue, May 10, 2022 at 10:10 AM Roger Quadros <rogerq@xxxxxxxxxx> wrote:
>> On 10/05/2022 11:06, Geert Uytterhoeven wrote:
>>> On Tue, May 10, 2022 at 9:40 AM Roger Quadros <rogerq@xxxxxxxxxx> wrote:
>>>> On 10/05/2022 10:30, Geert Uytterhoeven wrote:
>>>>> On Tue, May 10, 2022 at 9:22 AM Roger Quadros <rogerq@xxxxxxxxxx> wrote:
>>>>>> On 09/05/2022 16:48, Geert Uytterhoeven wrote:
>>>>>>> The Texas Instruments OMAP General Purpose Memory Controller (GPMC) is
>>>>>>> only present on TI OMAP2/3/4/5, AM33xx, AM43x, DRA7xx, TI81xx, and K3
>>>>>>> SoCs.  Hence add a dependency on ARCH_OMAP2PLUS || ARCH_K3, to prevent
>>>>>>> asking the user about this driver when configuring a kernel without
>>>>>>> OMAP2+ or K3 SoC family support.
>>>>>>>
>>>>>>> Fixes: be34f45f0d4aa91c ("memory: omap-gpmc: Make OMAP_GPMC config visible and selectable")
>>>>>>> Signed-off-by: Geert Uytterhoeven <geert+renesas@xxxxxxxxx>
>>>
>>>> Could you please also add ARCH_KEYSTONE in the 'depends on' list
>>>> as some SoCs in that architecture do have the GPMC block.
>>>
>>> Are you sure? AFAICS, none of the Keystone DTS files have device
>>> nodes that are compatible with the match list in the omap-gpmc driver.
>>
>> Yes, the 66AK2G12 SoC contains the GPMC module. [1]
>>
>>> Or perhaps the GPMC support still has to be added to the Keystone
>>> DTS files (and or driver)?
>>
>> That's most likely the case.
> 
> So would it make sense to compile the omap-gpmc driver on keystone
> yet, or does that need the introduction of e.g. a ti,k2g-gpmc compatible
> value first, and thus should it be postponed?

It doesn't harm to be available for keystone already.
Maybe it will save TI Keystone users some pain as to why OMAP_GPMC is no longer
available for Keystone. Let's not affect such users. Thanks!

cheers,
-roger