Re: [PATCH V4 3/5] arm64: dts: nuvoton: Add initial support for MA35D1

[Jacky Huang]

On 2022/5/10 下午 03:01, Arnd Bergmann wrote:
> On Tue, May 10, 2022 at 5:25 AM Jacky Huang <ychuang3@xxxxxxxxxxx> wrote:
> > Add the initial device tree files for Nuvoton MA35D1 Soc.
> >
> > Signed-off-by: Jacky Huang <ychuang3@xxxxxxxxxxx>
> > ---
> > +
> > +/ {
> > +       model = "Nuvoton MA35D1-EVB";
> > +       compatible = "nuvoton,ma35d1-evb", "nuvoton,ma35d1";
> > +
> > +       chosen {
> > +               stdout-path = "serial0:115200n8";
> > +       };
> Something seems to be missing here: you set the console to the serial0
> alias, but that is not defined anywhere, and the ma35d1.dtsi file does not
> appear to define any UART at all. Are you still missing the driver for this?
>
> Please add a more detailed description in the changelog text above that
> explains what kind of SoC this is (maybe a link to the product web page,
> if there is one), and a status of how complete the support is: which drivers
> are already merged, and which ones are still being worked on?
>
>          Arnd

Hi Arnd,

The serial driver is ready 
(https://github.com/OpenNuvoton/MA35D1_linux-5.4.y/blob/master/drivers/tty/serial/ma35d1_serial.c),
but we have to review the coding style and porting it from Linux 5.4.y 
to 5.18.

In the next patch version, I will added a brief introduction about 
MA35D1 in the cover-letter [PATCH 0/5].

Thanks for your review.

Sincerely,
Jacky Huang