Re: [PATCH] cpufreq: mediatek: Fix potential deadlock problem in mtk_cpufreq_set_target

[Jiabing Wan]

On 2022/5/10 16:50, Viresh Kumar wrote:
> On 10-05-22, 16:26, Jiabing Wan wrote:
> > Hi, Viresh Kumar
> >
> > On 2022/5/10 16:12, Viresh Kumar wrote:
> > > On 10-05-22, 16:01, Wan Jiabing wrote:
> > > > Fix following coccichek error:
> > > > ./drivers/cpufreq/mediatek-cpufreq.c:199:2-8: preceding lock on line
> > > > ./drivers/cpufreq/mediatek-cpufreq.c:208:2-8: preceding lock on line
> > > >
> > > > mutex_lock is acquired but not released before return.
> > > > Use 'goto out' to help releasing the mutex_lock.
> > > >
> > > > Fixes: c210063b40ac ("cupful: mediatek: Add opp notification support")
> > > cupful ??
> > Sorry for the typo...
> Did you write this line by hand or generate it with Git ? There shouldn't be a
> typo here.

Yes, I write this line by hand.
There must be something wrong when copying the subject line.

Maybe I should find some tools in git to avoid it in the future.
> > By the way, is this patch correct?
> >
> > I am not sure whether it should return with the mutex_lock.
> > But IMO, it should release the lock before return.
> Yes, we need to release the lock.
OK, I'll fix it in v2.

Thanks,
Wan Jiabing