Re: [PATCH v2] cpufreq: mediatek: Fix potential deadlock problem in mtk_cpufreq_set_target

[Jiabing Wan]

On 2022/5/10 17:12, Viresh Kumar wrote:
> On 10-05-22, 17:05, Wan Jiabing wrote:
> > Fix following coccichek error:
> > ./drivers/cpufreq/mediatek-cpufreq.c:199:2-8: preceding lock on line
> > ./drivers/cpufreq/mediatek-cpufreq.c:208:2-8: preceding lock on line
> >
> > mutex_lock is acquired but not released before return.
> > Use 'goto out' to help releasing the mutex_lock.
> >
> > Fixes: c210063b40ac ("cpufreq: mediatek: Add opp notification support")
> > Signed-off-by: Wan Jiabing <wanjiabing@xxxxxxxx>
> You should have added the review tag you received.
>
> Applied. Thanks.

Oh, yes.  I would add the "Reviewed-by:" tag only if someone sends
this tag to me.

Like:
[0] https://lore.kernel.org/all/YnkvM5iuSuAOqBg+@xxxxxxx/
[1] 
https://lore.kernel.org/all/20220510015521.2542096-1-wanjiabing@xxxxxxxx/

If not explicitly stated, I am afraid to add some wrong "Reviewed-by:"
tags which might bother maintainers.

Thanks a lot for your priceless advice!

Wan Jiabing