Re: [PATCH v2] cpufreq: mediatek: Fix potential deadlock problem in mtk_cpufreq_set_target

From: Jiabing Wan
Date: Tue May 10 2022 - 05:37:31 EST




On 2022/5/10 17:28, Viresh Kumar wrote:
On 10-05-22, 17:23, Jiabing Wan wrote:

On 2022/5/10 17:12, Viresh Kumar wrote:
On 10-05-22, 17:05, Wan Jiabing wrote:
Fix following coccichek error:
./drivers/cpufreq/mediatek-cpufreq.c:199:2-8: preceding lock on line
./drivers/cpufreq/mediatek-cpufreq.c:208:2-8: preceding lock on line

mutex_lock is acquired but not released before return.
Use 'goto out' to help releasing the mutex_lock.

Fixes: c210063b40ac ("cpufreq: mediatek: Add opp notification support")
Signed-off-by: Wan Jiabing <wanjiabing@xxxxxxxx>
You should have added the review tag you received.

Applied. Thanks.
Oh, yes.  I would add the "Reviewed-by:" tag only if someone sends
this tag to me.
Didn't you get this ?

https://lore.kernel.org/linux-mediatek/304e7eefbb57e9c938737b64fbb515201c7944b8.camel@xxxxxxxxxxxx/

Oh, sorry! there might be some problem in my email-server.
I didn't get this email and I also didn't see this email on LKML lore.

So I missed this email.
Sorry for my mistake.

Wan Jiabing