Re: [PATCH] clk: bcm2835: fix bcm2835_clock_choose_div

[Maxime Ripard]

On Sat, May 07, 2022 at 11:26:28AM +0200, Stefan Wahren wrote:
> Am 03.05.22 um 16:58 schrieb Maxime Ripard:
> > Hi,
> > 
> > On Thu, Apr 28, 2022 at 08:30:10PM +0200, Stefan Wahren wrote:
> > > The commit 09e3b18ca5de ("clk: bcm2835: Remove unused variable")
> > > accidentially breaks the behavior of bcm2835_clock_choose_div() and
> > > booting of Raspberry Pi. The removed do_div macro call had side effects,
> > > so we need to restore it.
> > > 
> > > Fixes: 09e3b18ca5de ("clk: bcm2835: Remove unused variable")
> > > Signed-off-by: Stefan Wahren <stefan.wahren@xxxxxxxx>
> > I only found this patch after debugging why the HDMI driver was
> > returning -EINVAL at probe on -rc5.
> > 
> > Acked-by: Maxime Ripard <maxime@xxxxxxxxxx>
> > Tested-by: Maxime Ripard <maxime@xxxxxxxxxx>
> 
> Thanks,
> 
> does this go via clk-fixes?

Yep, it should.

Stephen, could we merge this?

Maxime

Attachment: signature.asc
Description: PGP signature