Re: [PATCH] niu: Add "overloaded" struct page union member

[Kees Cook]

On Tue, May 10, 2022 at 12:27:53AM -0700, Christoph Hellwig wrote:
> On Mon, May 09, 2022 at 03:23:33PM -0700, Kees Cook wrote:
> > The randstruct GCC plugin gets upset when it sees struct addresspace
> > (which is randomized) being assigned to a struct page (which is not
> > randomized):
> 
> Well, the right fix here is to remove this abuse from the driver, not
> to legitimize it as part of a "driver" patch touching a core mm header

Right, I didn't expect anyone to like the new "overloaded" member.
Mainly I'd just like to understand how niu _should_ be fixed. Is using
the "private" member the correct thing here?

> that doesn't even cc the mm list.

Oops, yes, sorry.

-- 
Kees Cook