Re: [RFC PATCH] getting misc stats/attributes via xattr API

From: Christian Brauner
Date: Tue May 10 2022 - 12:00:32 EST


On Tue, May 10, 2022 at 05:47:13PM +0200, Miklos Szeredi wrote:
> On Tue, 10 May 2022 at 17:30, Christian Brauner <brauner@xxxxxxxxxx> wrote:
>
> > But now we're in the process of extending the *xattr() calls to operate
> > on mounts and filesystems so an additional getfsattr() (or another name)
> > is not fragmentation imho. And I definitely don't think this would
> > qualify as "crazy".
>
> In that spirit st_dev does not belong in struct stat, because that is
> the property of the block device, not the inode.
>
> But I feel we are going round in circles, lets please not get hung up
> on this issue. Linus will have the final word on which variant (if
> either) is going to go in.

Well yes, I'm obviously not going to be d*ck about it and go around
NAKing it just because I didn't get my favorite name but I at least
want to register my strong opposition to the current "unification"
approach loud and clear. :)