Re: [PATCH] powerpc/eeh: Drop redundant spinlock initialization

[Tyrel Datwyler]

On 5/10/22 02:53, Haowen Bai wrote:
> slot_errbuf_lock has declared and initialized by DEFINE_SPINLOCK,
> so we don't need to spin_lock_init again, drop it.
> 
> Signed-off-by: Haowen Bai <baihaowen@xxxxxxxxx>
> ---
>  arch/powerpc/platforms/pseries/eeh_pseries.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/arch/powerpc/platforms/pseries/eeh_pseries.c b/arch/powerpc/platforms/pseries/eeh_pseries.c
> index f9af879c0222..77b476093e06 100644
> --- a/arch/powerpc/platforms/pseries/eeh_pseries.c
> +++ b/arch/powerpc/platforms/pseries/eeh_pseries.c
> @@ -848,7 +848,6 @@ static int __init eeh_pseries_init(void)
>  	}
> 
>  	/* Initialize error log lock and size */

Update the comment, or just drop it entirely?

-Tyrel

> -	spin_lock_init(&slot_errbuf_lock);
>  	eeh_error_buf_size = rtas_token("rtas-error-log-max");
>  	if (eeh_error_buf_size == RTAS_UNKNOWN_SERVICE) {
>  		pr_info("%s: unknown EEH error log size\n",