Re: [PATCH v3 1/2] ath9k: fix use-after-free in ath9k_hif_usb_rx_cb

From: Pavel Skripkin
Date: Tue May 10 2022 - 15:26:58 EST


Hi Tetsuo,

On 5/6/22 02:31, Tetsuo Handa wrote:
On 2022/05/06 4:09, Pavel Skripkin wrote:
And we can meet NULL defer even if we leave drv_priv = priv initialization
on it's place.

I didn't catch the location. As long as "htc_handle->drv_priv = priv;" is done
before complete_all(&hif_dev->fw_done) is done, is something wrong?


I don't really remember why I said that, but looks like I just haven't opened callbacks' code.

OK. Then, why not accept Pavel's patch?

As you might expect, I have same question. This series is under review for like 7-8 months.

I have no ath9 device, so I can't test it on real hw, so somebody else should do it for me. It's requirement to get patch accepted.



With regards,
Pavel Skripkin

Attachment: OpenPGP_signature
Description: OpenPGP digital signature