Re: [PATCH v4 0/2] Input: cros-ec-keyb: Better matrixless support

From: Prashant Malani
Date: Tue May 10 2022 - 19:04:23 EST


Hi Dmitry,

On May 03 13:42, Stephen Boyd wrote:
> This is a followup to my previous patch[1] that skips keyboard registration
> when the matrix properties aren't present. This adds a compatible string
> for this scenario so we can ease existing DTBs over to the new design.
>
> Changes from v3 (https://lore.kernel.org/r/20220503042242.3597561-1-swboyd@xxxxxxxxxxxx):
> * s/register_keyboard/has_keyboard/
> * Pick up review tags
> * Indicate properties are required in example #2 in yaml file
>
> Changes from v2 (https://lore.kernel.org/r/20220429233112.2851665-1-swboyd@xxxxxxxxxxxx):
> * Drop rows/cols check now that compatible schema handles it
> * Make binding require rows,cols,keymap for cros-ec-keyb compatible
>
> Changes from v1 (https://lore.kernel.org/r/20220427203026.828183-1-swboyd@xxxxxxxxxxxx):
> * Better enforcement of properties in DT binding
> * Skip registration by means of adding compatible to device id list
>
> Stephen Boyd (2):
> dt-bindings: google,cros-ec-keyb: Introduce switches only compatible
> Input: cros-ec-keyb - skip keyboard registration w/o cros-ec-keyb
> compatible

Do these need input maintainers Acked-by? Also, should these go through
the chrome-platform branch?

Thanks,

-Prashant
>
> .../bindings/input/google,cros-ec-keyb.yaml | 87 +++++++++++++++++--
> drivers/input/keyboard/cros_ec_keyb.c | 19 ++--
> 2 files changed, 91 insertions(+), 15 deletions(-)
>
> Cc: Krzysztof Kozlowski <krzk+dt@xxxxxxxxxx>
> Cc: Rob Herring <robh+dt@xxxxxxxxxx>
> Cc: <devicetree@xxxxxxxxxxxxxxx>
> Cc: Benson Leung <bleung@xxxxxxxxxxxx>
> Cc: Guenter Roeck <groeck@xxxxxxxxxxxx>
> Cc: Douglas Anderson <dianders@xxxxxxxxxxxx>
> Cc: Hsin-Yi Wang <hsinyi@xxxxxxxxxxxx>
> Cc: "Joseph S. Barrera III" <joebar@xxxxxxxxxxxx>
>
> [1] https://lore.kernel.org/all/20220425210726.3813477-1-swboyd@xxxxxxxxxxxx/
>
> base-commit: 4352e23a7ff2f8a4ff229dd1283ed2f2b708ec51
> --
> https://chromeos.dev
>
>