RE: [PATCH v7 3/8] watchdog: hpe-wdt: Introduce HPE GXP Watchdog

From: Hawkins, Nick
Date: Tue May 10 2022 - 19:57:58 EST


On 5/6/22 12:13, nick.hawkins@xxxxxxx wrote:
> From: Nick Hawkins <nick.hawkins@xxxxxxx>
>
> + /* The register area where the timer and watchdog reside is disarranged.
> + * Hence mapping individual register blocks for the timer and watchdog
> + * is not recommended as they would have access to each others
> + * registers. Based on feedback the watchdog is no longer part of the
> + * device tree file and the timer driver now creates the watchdog as a
> + * child device. During the watchdogs creation, the timer driver passes
> + * the base address to the watchdog over the private interface.
> + */

/*
* Please use standard multi-line comments in the watchdog subsystem.
*/

Hi Guenter,

Thank you for the feedback. I will fix this with a v8 version of the patchset.

-Nick