Re: [PATCH next v3 2/2] arm64: dts: mediatek: mt8195: enable usb remote wakeup

[Macpaul Lin]

On Tue, 2022-05-10 at 20:10 +0800, Chunfeng Yun wrote:
> Enable USB remote wakeup of all four xHCI controller
> 
> Reviewed-by: AngeloGioacchino Del Regno <
> angelogioacchino.delregno@xxxxxxxxxxxxx>
> Signed-off-by: Chunfeng Yun <chunfeng.yun@xxxxxxxxxxxx>
> ---
> v3: add reviewed-by AngeloGioacchino;
> 
> NOTE:
>   based on v5.18-next/dts64 of matthias.bgg's branch
> 
> v2: no changes, based on new version of mt8195.dtsi
> ---
>  arch/arm64/boot/dts/mediatek/mt8195.dtsi | 8 ++++++++
>  1 file changed, 8 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/mediatek/mt8195.dtsi
> b/arch/arm64/boot/dts/mediatek/mt8195.dtsi
> index d5bc4cf5f4ac..3ad14e0e0956 100644
> --- a/arch/arm64/boot/dts/mediatek/mt8195.dtsi
> +++ b/arch/arm64/boot/dts/mediatek/mt8195.dtsi
> @@ -573,6 +573,8 @@
>  				 <&apmixedsys CLK_APMIXED_USB1PLL>,
>  				 <&infracfg_ao
> CLK_INFRA_AO_SSUSB_XHCI>;
>  			clock-names = "sys_ck", "ref_ck", "mcu_ck",
> "xhci_ck";
> +			mediatek,syscon-wakeup = <&pericfg 0x400 103>;
> +			wakeup-source;
>  			status = "disabled";
>  		};
>  
> @@ -636,6 +638,8 @@
>  				 <&apmixedsys CLK_APMIXED_USB1PLL>,
>  				 <&pericfg_ao
> CLK_PERI_AO_SSUSB_1P_XHCI>;
>  			clock-names = "sys_ck", "ref_ck",
> "mcu_ck","xhci_ck";
> +			mediatek,syscon-wakeup = <&pericfg 0x400 104>;
> +			wakeup-source;
>  			status = "disabled";
>  		};
>  
> @@ -655,6 +659,8 @@
>  				 <&topckgen CLK_TOP_SSUSB_P2_REF>,
>  				 <&pericfg_ao
> CLK_PERI_AO_SSUSB_2P_XHCI>;
>  			clock-names = "sys_ck", "ref_ck", "xhci_ck";
> +			mediatek,syscon-wakeup = <&pericfg 0x400 105>;
> +			wakeup-source;
>  			status = "disabled";
>  		};
>  
> @@ -674,6 +680,8 @@
>  				 <&topckgen CLK_TOP_SSUSB_P3_REF>,
>  				 <&pericfg_ao
> CLK_PERI_AO_SSUSB_3P_XHCI>;
>  			clock-names = "sys_ck", "ref_ck", "xhci_ck";
> +			mediatek,syscon-wakeup = <&pericfg 0x400 106>;
> +			wakeup-source;
>  			status = "disabled";
>  		};
>  

Tested-by: Macpaul Lin <macpaul.lin@xxxxxxxxxxxx>

Test method: test build pass and boot pass based on 'for-next' branch.

N
ote:
System suspend and resume of MT8195 has not been ready or enabled
on mainline. We cannot verify USB Host remote wake-up on mainline code,
but the settings and function works when applied to MediaTek's internal
working tree.

Regards,
Macpaul Lin