Re: [PATCH] RISC-V: Remove IORESOURCE_BUSY flag for no-map reserved memory

From: Conor.Dooley
Date: Wed May 11 2022 - 07:32:45 EST


On 11/05/2022 12:24, Xianting Tian wrote:
> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
>
> Commit 00ab027a3b82 ("RISC-V: Add kernel image sections to the resource tree")
> added IORESOURCE_BUSY flag for no-map reserved memory, this casued
> devm_ioremap_resource() failed for the no-map reserved memory in subsequent
> operations of related driver, so remove the IORESOURCE_BUSY flag.
>
> The code to reproduce the issue,
> dts:
> mem0: memory@a0000000 {
> reg = <0x0 0xa0000000 0 0x1000000>;
> no-map;
> };
>
> &test {
> status = "okay";
> memory-region = <&mem0>;
> };
>
> code:
> np = of_parse_phandle(pdev->dev.of_node, "memory-region", 0);
> ret = of_address_to_resource(np, 0, &r);
> base = devm_ioremap_resource(&pdev->dev, &r);
> // base = -EBUSY
>
> Fixes: 00ab027a3b82 ("RISC-V: Add kernel image sections to the resource tree")
> Reported-by: Huaming Jiang <jianghuaming.jhm@xxxxxxxxxxxxxxx>
> Reviewed-by: Guo Ren <guoren@xxxxxxxxxx>
> CC: Nick Kossifidis <mick@xxxxxxxxxxxx>
> Signed-off-by: Xianting Tian <xianting.tian@xxxxxxxxxxxxxxxxx>

Hey Xianting,
This resend is no different to the patch you sent 5 mins ago, right?
Thanks,
Conor.