Re: [PATCH v1] ARM: A9: Add ARM ERRATA 764319 workaround

From: Arnd Bergmann
Date: Wed May 11 2022 - 09:17:00 EST


On Wed, May 11, 2022 at 2:59 PM Verdun, Jean-Marie <verdun@xxxxxxx> wrote:
>
> Hi Arnd,
>
> > If it doesn't work, then there is no point trying. You could try
> > changing the exception
> > handling so it searches the ex_table for Undefined Instruction
> > exceptions as well,
> > but that's probably more complicated.
>
> I looked yesterday evening and share Will's point of view, I don't
> really see how it could work and believe unfortunately that
> we have to stay with the undef_hook approach. Let's us know if
> you believe some improvements are required to the current patch.
>
> Let's see the positive aspect we learnt something, and if we have
> to face additional issue, we have that option open.

The current patch looks reaonable to me then, please add

Reviewed-by: Arnd Bergmann <arnd@xxxxxxxx>

and submit it to Russell's patch tracker at
https://www.arm.linux.org.uk/developer/patches/info.php

with one small change applied: the 'oslsr_fault' variable should
be marked "static".

> Side question: Does any of you will attend Open Source Summit North America ?
> I will be there with Nick and HPE team to introduce our GXP Asic during a couple
> of talks. Would be great if we could spend some time together.

I have no plans to attend at the moment.

Arnd