Re: [PATCH 1/7] kthread: Don't allocate kthread_struct for init and umh

From: Eric W. Biederman
Date: Wed May 11 2022 - 13:42:00 EST


"Eric W. Biederman" <ebiederm@xxxxxxxxxxxx> writes:

> Thomas Gleixner <tglx@xxxxxxxxxxxxx> writes:
>
>> I'm worried that there are more of these issues lurking. Haven't looked
>> yet.
>
> I looked earlier and I missed this one. I am going to look again today,
> along with applying the obvious fix to task_tick_numa.

So I have just looked again and I don't see anything. There are a
couple of subtle issues on x86. Especially with saving floating
point but as I read the code copy_thread initializes things
properly so that code that doesn't touch floating point registers
doesn't need to do anything.

The important thing for lurking issues is that even if I missed
something practically all of the uses of PF_KTHREAD are on x86
or generic code so they should be flushed out quickly.

Eric