Re: [PATCH V10 14/44] mm/pkeys: Introduce pks_set_readwrite()

From: Ira Weiny
Date: Wed May 11 2022 - 13:59:49 EST


On Tue, May 10, 2022 at 08:15:45PM -0700, Kees Cook wrote:
> On Tue, May 10, 2022 at 10:26:43PM +0000, Edgecombe, Rick P wrote:
> > v2:
> > https://lore.kernel.org/lkml/20210830235927.6443-1-rick.p.edgecombe@xxxxxxxxx/#r
> >
> > Mostly it fit together pretty easily, but there was memory overhead
> > required to protect the page tables that map the direct map fully
> > (unless a better solution can be found).
>
> Oh my, I totally missed this. Yay for Too Much Email Every Day. ;)
>
> I'll give this a read; thanks for working on it!
>
> Also, can you speak to the schedule of availability for PKS?

Sapphire Rapids is the first CPU. But I can't speak to any dates.

I'm reworking the series now with your changes.

Thanks again for the review!
Ira