Re: [v4 2/3] phy: qcom-snps: Add support for overriding phy tuning parameters
From: kernel test robot
Date: Wed May 11 2022 - 17:05:31 EST
Hi Krishna,
Thank you for the patch! Perhaps something to improve:
[auto build test WARNING on robh/for-next]
[also build test WARNING on krzk/for-next linus/master v5.18-rc6 next-20220511]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/intel-lab-lkp/linux/commits/Krishna-Kurapati/Add-QCOM-SNPS-PHY-overriding-params-support/20220511-232858
base: https://git.kernel.org/pub/scm/linux/kernel/git/robh/linux.git for-next
config: m68k-allyesconfig (https://download.01.org/0day-ci/archive/20220512/202205120425.gScyEI7N-lkp@xxxxxxxxx/config)
compiler: m68k-linux-gcc (GCC) 11.3.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/intel-lab-lkp/linux/commit/48c46f24873c92d3e16904af9e654962d0b923f1
git remote add linux-review https://github.com/intel-lab-lkp/linux
git fetch --no-tags linux-review Krishna-Kurapati/Add-QCOM-SNPS-PHY-overriding-params-support/20220511-232858
git checkout 48c46f24873c92d3e16904af9e654962d0b923f1
# save the config file
mkdir build_dir && cp config build_dir/.config
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.3.0 make.cross W=1 O=build_dir ARCH=m68k SHELL=/bin/bash drivers/phy/qualcomm/
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@xxxxxxxxx>
All warnings (new ones prefixed by >>):
drivers/phy/qualcomm/phy-qcom-snps-femto-v2.c: In function 'qcom_snps_hsphy_read_override_param_seq':
>> drivers/phy/qualcomm/phy-qcom-snps-femto-v2.c:541:42: warning: initialization discards 'const' qualifier from pointer target type [-Wdiscarded-qualifiers]
541 | struct override_param_map *cfg = of_device_get_match_data(dev);
| ^~~~~~~~~~~~~~~~~~~~~~~~
vim +/const +541 drivers/phy/qualcomm/phy-qcom-snps-femto-v2.c
534
535 static void qcom_snps_hsphy_read_override_param_seq(struct device *dev)
536 {
537 struct device_node *node = dev->of_node;
538 s32 val;
539 int ret, i;
540 struct qcom_snps_hsphy *hsphy;
> 541 struct override_param_map *cfg = of_device_get_match_data(dev);
542
543 hsphy = dev_get_drvdata(dev);
544
545 for (i = 0; i < ARRAY_SIZE(phy_seq_props); i++) {
546 ret = of_property_read_s32(node, phy_seq_props[i], &val);
547 if (!ret) {
548 dev_dbg(&hsphy->phy->dev, "Read param: %s val: %d\n",
549 phy_seq_props[i], val);
550 qcom_snps_hsphy_override_param_update_val(cfg[i], val,
551 &hsphy->update_seq_cfg[i]);
552 }
553 }
554 }
555
--
0-DAY CI Kernel Test Service
https://01.org/lkp