[PATCH 1/2] HID: nintendo: fix face button mappings

From: Max Fletcher
Date: Wed May 11 2022 - 20:15:48 EST


Previously, A and B would match the Xbox layout, but X and Y were incorrectly swapped. This corrects it so that X and Y match the Xbox layout.

Signed-off-by: Max Fletcher <fletcher0max@xxxxxxxxx>
---
drivers/hid/hid-nintendo.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/drivers/hid/hid-nintendo.c b/drivers/hid/hid-nintendo.c
index 2204de889739..7735971ede3f 100644
--- a/drivers/hid/hid-nintendo.c
+++ b/drivers/hid/hid-nintendo.c
@@ -1351,10 +1351,10 @@ static void joycon_parse_report(struct joycon_ctlr *ctlr,
input_report_key(dev, BTN_START, btns & JC_BTN_PLUS);
input_report_key(dev, BTN_THUMBR, btns & JC_BTN_RSTICK);
input_report_key(dev, BTN_MODE, btns & JC_BTN_HOME);
- input_report_key(dev, BTN_WEST, btns & JC_BTN_Y);
- input_report_key(dev, BTN_NORTH, btns & JC_BTN_X);
- input_report_key(dev, BTN_EAST, btns & JC_BTN_A);
- input_report_key(dev, BTN_SOUTH, btns & JC_BTN_B);
+ input_report_key(dev, BTN_X, btns & JC_BTN_Y);
+ input_report_key(dev, BTN_Y, btns & JC_BTN_X);
+ input_report_key(dev, BTN_B, btns & JC_BTN_A);
+ input_report_key(dev, BTN_A, btns & JC_BTN_B);
}

input_sync(dev);
@@ -1578,7 +1578,7 @@ static const unsigned int joycon_button_inputs_l[] = {

static const unsigned int joycon_button_inputs_r[] = {
BTN_START, BTN_MODE, BTN_THUMBR,
- BTN_SOUTH, BTN_EAST, BTN_NORTH, BTN_WEST,
+ BTN_A, BTN_B, BTN_Y, BTN_X,
BTN_TR, BTN_TR2,
0 /* 0 signals end of array */
};
--
2.35.3