Re: [PATCH v5 01/12] modpost: split the section mismatch checks into section-check.c

[Masahiro Yamada]

On Thu, May 12, 2022 at 7:28 AM Nick Desaulniers
<ndesaulniers@xxxxxxxxxx> wrote:
>
> On Wed, May 11, 2022 at 9:49 AM Masahiro Yamada <masahiroy@xxxxxxxxxx> wrote:
> >
> > modpost.c is too big, and the half of the code is for section checks.
> > Split it.
> >
> > Also, move some related typedefs and macros from modpost.h to
> > section-check.c
> >
> > Copy Sam's Copyright there. Commit b39927cf4cc5 ("kbuild: check for
> > section mismatch during modpost stage") is the initial work for the
> > section checks.
> >
> > Signed-off-by: Masahiro Yamada <masahiroy@xxxxxxxxxx>
>
> Reviewed-by: Nick Desaulniers <ndesaulniers@xxxxxxxxxx>
>
> Sorry again for my "brain fart" in reviewing the global var in v4. :(
> I think my blood sugar was getting low or something...

Never mind.
Thanks for the close review all the time!

>
> > ---
> >
> > Changes in v5:
> >    - Fix the build error  (spotted by Nathan)
> >    - Do not do codying style changes  (Suggested by Nick)
>
> I'm surprised the style changes didn't show up in v5 as a later patch
> in the series. I wasn't against them in general, just thought it would
> be easier to review if they were distinct commits.


I just postponed the coding style fixes
because they are not essential for my main goal
in this patch set.

A lot of old code exists in modpost.
We can improve it later.


-- 
Best Regards
Masahiro Yamada