Re: [PATCH] leds: netxbig: Fix refcount leak in netxbig_leds_get_of_pdata

[Pavel Machek]

Hi!

> of_parse_phandle() returns a node pointer with refcount
> incremented, we should use of_node_put() on it when not needed anymore.
> When of_find_device_by_node() fails, of_node_put() is missing.

Can you take a look at the code and simplify it? AFAICT the node_put
should go right after

       gpio_ext_pdev = of_find_device_by_node(gpio_ext_np);


. Best regards,
								Pavel
-- 
People of Russia, stop Putin before his war on Ukraine escalates.

Attachment: signature.asc
Description: Digital signature