Re: [PATCH v7 2/4] kexec, KEYS: make the code in bzImage64_verify_sig generic

From: Coiby Xu
Date: Thu May 12 2022 - 02:55:37 EST


On Thu, May 12, 2022 at 02:22:57PM +0800, Baoquan He wrote:
On 05/12/22 at 12:33pm, Coiby Xu wrote:
[...]
> Just to make clear , is this patch fixing an issue, or it's just an
> preparation for later patch's use?
>
> Or I should ask in another way, any problem is solved with this patch?

At least it doesn't fix an issue that satisfy the criteria listed in
https://www.kernel.org/doc/html/latest/process/stable-kernel-rules.html

Then it should not be CC-ed to stable.

OK, I'll drop "CC:" in next version.



>
>
> > > Reviewed-by: Michal Suchanek <msuchanek@xxxxxxx>
> > > Signed-off-by: Coiby Xu <coxu@xxxxxxxxxx>
> > > ---
> >
> > You can put the note here, it won't be added to commit log when merged.
> > Maybe it can be removed when merged.

Thanks for the suggestion! Shall I send a version to fix this problem or
can I just bother the maintainer to remove it?

Better send a clean one, it will save maintainer's time, they can pick
it directly.

Thanks for the confirmation! I'll simply delete them because,
1. these notes don't make sense anymore if I don't CC the patches to the stable
tree 2. I've explained in the cover letter the first two patches
are the prerequisite patches for the 3rd patch.

--
Best regards,
Coiby