Re: [PATCH v3 21/23] ata: ahci-dwc: Add platform-specific quirks support

[Hannes Reinecke]

On 5/12/22 01:18, Serge Semin wrote:
> Some DWC AHCI SATA IP-core derivatives require to perform small platform
> or IP-core specific setups. They are too small to be placed in a dedicated
> driver. It's just much easier to have a set of quirks for them right in
> the DWC AHCI driver code. Since we are about to add such platform support,
> as a pre-requisite we introduce a platform-data based DWC AHCI quirks API.
> The platform data can be used to define the flags passed to the
> ahci_platform_get_resources() method, additional AHCI host-flags and a set
> of callbacks to initialize, re-initialize and clear the platform settings.
>
> Signed-off-by: Serge Semin <Sergey.Semin@xxxxxxxxxxxxxxxxxxxx>
>
> ---
>
> Changelog v2:
> - Change the local objects prefix from 'dwc_ahci_' to 'ahci_dwc_'.
>    (@Damien)
> ---
>   drivers/ata/ahci_dwc.c | 52 ++++++++++++++++++++++++++++++++++++++----
>   1 file changed, 48 insertions(+), 4 deletions(-)
This really could be merged with patch 19; as you're adding a new driver 
you might as well fold this patch in to avoid further modifications.

Cheers,

Hannes
--
Dr. Hannes Reinecke		           Kernel Storage Architect
hare@xxxxxxx			                  +49 911 74053 688
SUSE Software Solutions Germany GmbH, Maxfeldstr. 5, 90409 Nürnberg
HRB 36809 (AG Nürnberg), GF: Felix Imendörffer