Re: [PATCH net-next v2 2/2] net/smc: align the connect behaviour with TCP

From: Karsten Graul
Date: Thu May 12 2022 - 08:08:43 EST


On 12/05/2022 05:11, Guangguan Wang wrote:
> Connect with O_NONBLOCK will not be completed immediately
> and returns -EINPROGRESS. It is possible to use selector/poll
> for completion by selecting the socket for writing. After select
> indicates writability, a second connect function call will return
> 0 to indicate connected successfully as TCP does, but smc returns
> -EISCONN. Use socket state for smc to indicate connect state, which
> can help smc aligning the connect behaviour with TCP.
>
> Signed-off-by: Guangguan Wang <guangguan.wang@xxxxxxxxxxxxxxxxx>
> ---

Acked-by: Karsten Graul <kgraul@xxxxxxxxxxxxx>

Thank you.