Re: [PATCH] clk: qcom: rpmh: Set wake/sleep state for BCM clks

From: Alex Elder
Date: Thu May 12 2022 - 11:15:38 EST


On 5/11/22 5:04 PM, Stephen Boyd wrote:
Will you take this in fixes, or do you want me to pick it for 5.19?

I'm waiting for Taniya to reply. For all I know this has no effect
because there's some sort of copy/paste from one state to another. Until
then it doesn't seem like we should do anything.
Taniya told me that if there's no sleep or wake state set then active
state remains even when the subsystem is in sleep. Not exactly
copy/paste but at least it is consistent. We need a comment here so this
doesn't come up again.

If I understand what you're saying here, your original patch is not
necessary, but there should be a comment in the code that explains
why that is the case. Is that right? And am I right to assume you
will be sending out a patch with such a comment?

-Alex