Re: [PATCH V4 0/5] Add initial support for MA35D1 SoC

[Jacky Huang]

On 2022/5/12 下午 10:35, Arnd Bergmann wrote:
> On Thu, May 12, 2022 at 4:11 PM Krzysztof Kozlowski
> <krzysztof.kozlowski@xxxxxxxxxx> wrote:
> > On 10/05/2022 09:07, Arnd Bergmann wrote:
> > > On Tue, May 10, 2022 at 5:25 AM Jacky Huang <ychuang3@xxxxxxxxxxx> wrote:
> > > > This patch series adds initial support for Nuvoton MA35D1 SoC,
> > > > include initial dts and clock controller binding.
> > > This looks fine in principle, but we are getting close to the merge window and
> > > should finalize this quickly to make it into v5.19. I see that you don't have a
> > > console device, as commented in the .dts patch. Normally I prefer merging
> > > platforms only when there is at least rudimentary support for booting into
> > > an initramfs with a serial console, but this is a flexible rule.
> > I disagree. It does not look fine - does not pass `make dtbs_check` even
> > with Nuvoton bindings...
> Ok, thanks for taking a look. It was already late for 5.19 and missing the uart
> driver, so it was clear it had not seen actual runtime testing. Let's try
> aiming for 5.20 then.
>
>          Arnd

Thanks for your review and help.
I will run the dtbs_check, add binding document, and include serial 
driver in the next version.


sincerely,
Jacky Huang