Re: [PATCH] bus: mhi: host: Add support for Quectel EM120 FCCL project.

[Greg KH]

On Fri, May 13, 2022 at 03:00:25PM +0800, Yonglin Tan wrote:
> From: ylintan <yonglin.tan@xxxxxxxxxxx>
> 
>     This patch add VendorID/DeviceID definitions for EM120 FCCL project.
>     It has the same configration as Quectel EM160R-GL and EM120R-GL.
> 
>     Reviewed-by: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>
>     Reviewed-by: Hemant Kumar <hemantk@xxxxxxxxxxxxxx>
>     Reviewed-by: Manivannan Sadhasivam <manivannan.sadhasivam@xxxxxxxxxx>
>     Signed-off-by: Yonglin Tan <yonglin.tan@xxxxxxxxxxx>
> ---
>  drivers/bus/mhi/host/pci_generic.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/bus/mhi/host/pci_generic.c b/drivers/bus/mhi/host/pci_generic.c
> index 8416267..0a6469c 100644
> --- a/drivers/bus/mhi/host/pci_generic.c
> +++ b/drivers/bus/mhi/host/pci_generic.c
> @@ -557,6 +557,8 @@ static const struct pci_device_id mhi_pci_id_table[] = {
>  		.driver_data = (kernel_ulong_t) &mhi_quectel_em1xx_info },
>  	{ PCI_DEVICE(0x1eac, 0x1002), /* EM160R-GL (sdx24) */
>  		.driver_data = (kernel_ulong_t) &mhi_quectel_em1xx_info },
> +	{ PCI_DEVICE(0x1eac, 0x2001), /* EM120R-GL for FCCL (sdx24) */
> +		.driver_data = (kernel_ulong_t) &mhi_quectel_em1xx_info },
>  	/* T99W175 (sdx55), Both for eSIM and Non-eSIM */
>  	{ PCI_DEVICE(PCI_VENDOR_ID_FOXCONN, 0xe0ab),
>  		.driver_data = (kernel_ulong_t) &mhi_foxconn_sdx55_info },
> -- 
> 2.7.4
> 

Ok, please stop and take a minute and go through the basic "how do I
write a kernel patch" tutorial on kernelnewbies.org.

You are submitting a patch that has a number of obvious things wrong
with it:
	- invalid from: line that does not match the signed-off-by line
	- made up out of thin air "reviewed-by:" lines from people who
	  have OBVIOUSLY NOT REVIEWED THIS PATCH!
	- indented changelog text in an odd format
	- extra spaces in the subject line
	- no versioning in the subject line, or below the --- line as
	  the documentation requires

Please take some time off, and come back next week with this all fixed
up AFTER you have gone through the kernelnewbies tutorial AND you have
read all of the Documentation/process/submitting-patches.rst file.

thanks,

greg k-h