Re: [PATCH] m68knommu: fix undefined reference to `mach_get_rtc_pll'

[Arnd Bergmann]

On Fri, May 13, 2022 at 9:12 AM Geert Uytterhoeven <geert@xxxxxxxxxxxxxx> wrote:
> >
> > -#ifdef CONFIG_M68KCLASSIC
> > +#if defined(CONFIG_M68KCLASSIC) && defined(CONFIG_MMU)
> >  #if !IS_BUILTIN(CONFIG_RTC_DRV_GENERIC)
> >  void read_persistent_clock64(struct timespec64 *ts)
> >  {
>
> read_persistent_clock64() uses mach_hwclk(), which is provided by
> both setup_mm.c and setup_no.c, so it's always available?
> Albeit not populated by coldfire or nommu platform code, so I see
> the point in depending on MMU (no nommu Amiga support yet ;-).
>
> Perhaps rtc_ioctl() should depend on CONFIG_Q40?

I think the best cleanup would be to turn the q40 rtc support into a
standalone driver using rtc_register_device(), and completely
detaching it from the rtc_generic support in arch/m68k/kernel/time.c.

        Arnd