Re: [PATCH] crypto: hisilicon/sec - delele the flag CRYPTO_ALG_ALLOCATES_MEMORY

[yekai(A)]

On 2022/5/13 15:55, Kai Ye wrote:
> Should not to uses the CRYPTO_ALG_ALLOCATES_MEMORY in SEC2. The SEC2
> driver uses the pre-allocated buffers, including the src sgl pool, dst
> sgl pool and other qp ctx resources. (e.g. IV buffer, mac buffer, key
> buffer). The SEC2 driver doesn't allocate memory during request processing.
> The driver only maps software sgl to allocated hardware sgl during I/O. So
> here is fix it.
>
> Signed-off-by: Kai Ye <yekai13@xxxxxxxxxx>
> ---
>  drivers/crypto/hisilicon/sec2/sec_crypto.c | 2 --
>  1 file changed, 2 deletions(-)
>
> diff --git a/drivers/crypto/hisilicon/sec2/sec_crypto.c b/drivers/crypto/hisilicon/sec2/sec_crypto.c
> index a91635c348b5..6eebe739893c 100644
> --- a/drivers/crypto/hisilicon/sec2/sec_crypto.c
> +++ b/drivers/crypto/hisilicon/sec2/sec_crypto.c
> @@ -2113,7 +2113,6 @@ static int sec_skcipher_decrypt(struct skcipher_request *sk_req)
>  		.cra_driver_name = "hisi_sec_"sec_cra_name,\
>  		.cra_priority = SEC_PRIORITY,\
>  		.cra_flags = CRYPTO_ALG_ASYNC |\
> -		 CRYPTO_ALG_ALLOCATES_MEMORY |\
>  		 CRYPTO_ALG_NEED_FALLBACK,\
>  		.cra_blocksize = blk_size,\
>  		.cra_ctxsize = sizeof(struct sec_ctx),\
> @@ -2366,7 +2365,6 @@ static int sec_aead_decrypt(struct aead_request *a_req)
>  		.cra_driver_name = "hisi_sec_"sec_cra_name,\
>  		.cra_priority = SEC_PRIORITY,\
>  		.cra_flags = CRYPTO_ALG_ASYNC |\
> -		 CRYPTO_ALG_ALLOCATES_MEMORY |\
>  		 CRYPTO_ALG_NEED_FALLBACK,\
>  		.cra_blocksize = blk_size,\
>  		.cra_ctxsize = sizeof(struct sec_ctx),\

Please ignore this patch, There was a title misspelled, "delete->delele"


Thanks
Kai