Re: [PATCH 2/7] dt-bindings: pinctrl: qcom-pmic-gpio: Add pm6125 compatible

From: Marijn Suijten
Date: Fri May 13 2022 - 05:17:57 EST


On 2022-05-13 10:19:56, Krzysztof Kozlowski wrote:
> On 12/05/2022 00:06, Marijn Suijten wrote:
> > The pm6125 comes with 9 GPIOs, without holes.
> >
> > Signed-off-by: Marijn Suijten <marijn.suijten@xxxxxxxxxxxxxx>
> > Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@xxxxxxxxxxxxxx>
>
> It's the first version, how did the tag appear here?

We are friends and review each-others patches offline before spamming
the mailing list with them, to save readers and maintainers here from
pointing out glaring mistakes. I hope this is standard practice in
companies too, or do you recommend aganst us doing this?

> > ---
> > Documentation/devicetree/bindings/pinctrl/qcom,pmic-gpio.yaml | 2 ++
> > 1 file changed, 2 insertions(+)
>
>
> This will need fixups or rebasing on my sets of PMIC gpio schema cleanup:

Ack.

> https://lore.kernel.org/all/20220507194913.261121-1-krzysztof.kozlowski@xxxxxxxxxx/
> https://lore.kernel.org/all/20220508135932.132378-2-krzysztof.kozlowski@xxxxxxxxxx/
>
> Bjorn,
> let us know preferred order (who should rebase on who).

I prefer yours to be applied first, so that I can retest this
patchseries with stricter / more correct dt-bindings introduced by it.
My series can also be resent with the notice that it has already been
rebased on top of your series, after collecting more reviews. Where
necessary, I can review your series too if that helps getting it in
sooner.

- Marijn