RE: [PATCH 2/2] random: move initialization out of reseeding hot path

From: David Laight
Date: Fri May 13 2022 - 07:38:30 EST


From: Jason A. Donenfeld
> Sent: 13 May 2022 11:22
>
> On Fri, May 13, 2022 at 08:24:19AM +0200, Dominik Brodowski wrote:
> > > - if (!crng_ready()) {
> > > - crng_init = CRNG_READY;
> > > - finalize_init = true;
> > > - }
> > > + crng_init = CRNG_READY;
> >
> > Why unconditionally
>
> To avoid a useless branch.

Are you now dirtying a cache line that would
otherwise be clean?

David

-
Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1 1PT, UK
Registration No: 1397386 (Wales)