Re: [PATCH 4/6] mm/page_alloc: Remove unnecessary page == NULL check in rmqueue

From: Nicolas Saenz Julienne
Date: Fri May 13 2022 - 08:03:17 EST


On Thu, 2022-05-12 at 09:50 +0100, Mel Gorman wrote:
> The VM_BUG_ON check for a valid page can be avoided with a simple
> change in the flow. The ZONE_BOOSTED_WATERMARK is unlikely in general
> and even more unlikely if the page allocation failed so mark the
> branch unlikely.
>
> Signed-off-by: Mel Gorman <mgorman@xxxxxxxxxxxxxxxxxxx>
> Tested-by: Minchan Kim <minchan@xxxxxxxxxx>
> Acked-by: Minchan Kim <minchan@xxxxxxxxxx>
> ---

Reviewed-by: Nicolas Saenz Julienne <nsaenzju@xxxxxxxxxx>

Thanks,

--
Nicolás Sáenz