Re: [PATCH 1/7] perf test: Skip reason for suites with 1 test

[John Garry]

On 13/05/2022 17:34, Ian Rogers wrote:
> > > > john@localhost:~/acme/tools/perf> sudo ./perf test 63
> > > > 63: Test libpfm4 support : Skip (not compiled in)
> > > >
> > > > Although it is odd to have a single sub-test, is there a reason for
> > > > which we don't print its name? We print the name when there are multiple
> > > > sub-tests.
> > > The reason was to replicate the existing "perf test" behavior before
> > > the kunit style transition. The main place we get tests with a single
> > > sub-test is from the DEFINE_SUITE macro:
> > > https://git.kernel.org/pub/scm/linux/kernel/git/acme/linux.git/tree/tools/perf/tests/tests.h?h=perf/core#n67
> > > I agree it looks kind of weird and was inheriting the data structures
> > > from kunit and the format of the output from perf test.
> > Out of curiosity, which suite is this that you find only has a single
> > subtest? Does it possibly only have a single subtest as some others may
> > be compiled out?
> I was getting it when I added a skip message to the openat syscall
> tests in patch 3:
> https://lore.kernel.org/lkml/20220513040519.1499333-4-irogers@xxxxxxxxxx/
>
> I didn't see any changes with any existing tests.

I suppose it works when the suite has the same name as the subtest, so, 
FWIW:

Reviewed-by: John Garry <john.garry@xxxxxxxxxx>