Re: [PATCH] kselftest/cgroup: fix test_stress.sh to use OUTPUT dir

[Waiman Long]

On 5/13/22 12:20, Tejun Heo wrote:
> Can you send a quick patch?

Will do.

Cheers,
Longman

> Thanks.
>
> On Fri, May 13, 2022 at 6:19 AM Waiman Long <longman@xxxxxxxxxx> wrote:
> > On 5/12/22 10:34, Phil Auld wrote:
> > > Running cgroup kselftest with O= fails to run the with_stress test due
> > > to hardcoded ./test_core. Find test_core binary using the OUTPUT directory.
> > >
> > > Fixes: 1a99fcc035fb ("selftests: cgroup: Run test_core under interfering stress")
> > > Signed-off-by: Phil Auld <pauld@xxxxxxxxxx>
> > > ---
> > >    tools/testing/selftests/cgroup/test_stress.sh | 2 +-
> > >    1 file changed, 1 insertion(+), 1 deletion(-)
> > >
> > > diff --git a/tools/testing/selftests/cgroup/test_stress.sh b/tools/testing/selftests/cgroup/test_stress.sh
> > > index 15d9d5896394..109c044f715f 100755
> > > --- a/tools/testing/selftests/cgroup/test_stress.sh
> > > +++ b/tools/testing/selftests/cgroup/test_stress.sh
> > > @@ -1,4 +1,4 @@
> > >    #!/bin/bash
> > >    # SPDX-License-Identifier: GPL-2.0
> > >
> > > -./with_stress.sh -s subsys -s fork ./test_core
> > > +./with_stress.sh -s subsys -s fork ${OUTPUT}/test_core
> >
> > I would suggest using "${OUTPUT:-.}" as the variable OUTPUT may not be
> > defined if test_stress.sh is run interactively.
> >
> > Cheers,
> > Longman