Re: [PATCH v2 2/4] dt-bindings: arm: qcom: Add sc7180 Chromebook board bindings

From: Matthias Kaehlcke
Date: Fri May 13 2022 - 15:28:13 EST


On Fri, May 13, 2022 at 09:59:18AM -0700, Douglas Anderson wrote:
> This copy-pastes compatibles from sc7180-based boards from the device
> trees to the yaml file so that `make dtbs_check` will be happy.
>
> NOTES:
> - I make no attempt to try to share an "item" for all sc7180 based
> Chromebooks. Because of the revision matching scheme used by the
> Chromebook bootloader, at times we need a different number of
> revisions listed.
> - Some of the odd entries in here (like google,homestar-rev23 or the
> fact that "Google Lazor Limozeen without Touchscreen" changed from
> sku5 to sku6) are not typos but simply reflect reality.
> - Many revisions of boards here never actually went to consumers, but
> they are still in use within various companies that were involved in
> Chromebook development. Since Chromebooks are developed with an
> "upstream first" methodology, having these revisions supported with
> upstream Linux is important. Making it easy for Chromebooks to be
> developed with an "upstream first" methodology is valuable to the
> upstream community because it improves the quality of upstream and
> gets Chromebooks supported with vanilla upstream faster.
>
> This patch also adds a link to the Chromebook boot flow documentation
> to explain that Chromebooks don't use the scheme described for the
> Qualcomm bootloader.
>
> Signed-off-by: Douglas Anderson <dianders@xxxxxxxxxxxx>

Reviewed-by: Matthias Kaehlcke <mka@xxxxxxxxxxxx>