Re: [RFCv2 03/10] x86: Introduce userspace API to handle per-thread features

From: Kirill A. Shutemov
Date: Fri May 13 2022 - 19:10:27 EST


On Fri, May 13, 2022 at 05:34:12PM +0000, Edgecombe, Rick P wrote:
> On Fri, 2022-05-13 at 16:09 +0200, Alexander Potapenko wrote:
> > > +
> > > + /* Handle ARCH_THREAD_FEATURE_ENABLE */
> > > +
> > > + task->thread.features |= features;
> > > +out:
> > > + return task->thread.features;
> >
> > Isn't arch_prctl() supposed to return 0 on success?
>
> Hmm, good point. Maybe we'll need a struct to pass info in and out.

But values >0 are unused. I don't see why can't we use them.

--
Kirill A. Shutemov