Re: [PATCH V10 18/22] LoongArch: Add PCI controller support

[WANG Xuerui]

Hi,

On 5/14/22 16:03, Huacai Chen wrote:
> Loongson64 based systems are PC-like systems which use PCI/PCIe as its
> I/O bus, This patch adds the PCI host controller support for LoongArch.
>
> Signed-off-by: Jianmin Lv <lvjianmin@xxxxxxxxxxx>
> Signed-off-by: Huacai Chen <chenhuacai@xxxxxxxxxxx>
> ---
>   arch/loongarch/include/asm/dma.h |  13 +++
>   arch/loongarch/include/asm/pci.h |  40 +++++++
>   arch/loongarch/pci/acpi.c        | 172 +++++++++++++++++++++++++++++++
>   arch/loongarch/pci/pci.c         |  98 ++++++++++++++++++
>   4 files changed, 323 insertions(+)
>   create mode 100644 arch/loongarch/include/asm/dma.h
>   create mode 100644 arch/loongarch/include/asm/pci.h
>   create mode 100644 arch/loongarch/pci/acpi.c
>   create mode 100644 arch/loongarch/pci/pci.c

Admittedly I'm also not familiar with the PCI code in general, but from 
what little my knowledge currently is, the changes look okay. (At least 
the code style and naming of things are reasonable.)

So, albeit a rather weak one:

Reviewed-by: WANG Xuerui <git@xxxxxxxxxx>