Re: [PATCH v6 03/12] iommu: Add attach/detach_dev_pasid domain ops

[Baolu Lu]

On 2022/5/12 19:51, Jason Gunthorpe wrote:
> On Thu, May 12, 2022 at 08:00:59AM +0100, Jean-Philippe Brucker wrote:
>
> > > It is not "missing" it is just renamed to blocking_domain->ops->set_dev_pasid()
> > >
> > > The implementation of that function would be identical to
> > > detach_dev_pasid.
> >
> >    attach(dev, pasid, sva_domain)
> >    detach(dev, pasid, sva_domain)
> >
> > versus
> >
> >    set_dev_pasid(dev, pasid, sva_domain)
> >    set_dev_pasid(dev, pasid, blocking)
> >
> > we loose the information of the domain previously attached, and the SMMU
> > driver has to retrieve it to find the ASID corresponding to the mm.
>
> It would be easy to have the old domain be an input as well - the core
> code knows it.

Thanks a lot for all suggestions. I have posted a follow-up series for
this:

https://lore.kernel.org/linux-iommu/20220516015759.2952771-1-baolu.lu@xxxxxxxxxxxxxxx/

Let's discuss this there.

Best regards,
baolu