Re: [RFC PATCH v2] printk: console: Allow each console to have its own loglevel
From: Chris Down
Date: Sat May 21 2022 - 15:25:47 EST
Greg Kroah-Hartman writes:
You forgot what changed from v1 :(
Whoops! I must have accidentally nuked it when writing the mail.
The list should be:
- Dynamically allocate struct device*
- Document sysfs attributes in Documentation/ABI/
- Use sysfs_emit() instead of sprintf() in dev sysfs files
- Remove WARN_ON() for device_add/IS_ERR(console_class)
- Remove "soon" comment for kernel.printk, wait to discuss timeline with Petr
- Fix !CONFIG_PRINTK build
- Fix device_unregister() NULL dereference if called before class setup
- Add new documentation to MAINTAINERS
Anyway, the driver model interaction looks good to me, nice work, no
objections at all.
Great, thanks for checking it over :-)